[Bugfix] Add toast message for getting started / Fix Nav Bug for Traces #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
TackAdam
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
YANG-DB
approved these changes
Jul 23, 2024
ps48
reviewed
Jul 23, 2024
Comment on lines
+82
to
+87
| if (isNavGroupEnabled) { | ||
| chrome.setBreadcrumbs([...childBreadcrumbs]); | ||
| } else { | ||
| chrome.setBreadcrumbs([parentBreadcrumb, ...childBreadcrumbs]); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we try using
useEffect(() => {
setNavBreadCrumbs([], [parentBreadcrumb, ...childBreadcrumbs]);
}, [isNavGroupEnabled])
There was a problem hiding this comment.
Does not work unfortunately.
There was a problem hiding this comment.
In that case, can we please track this in an issue. Cause ideally we would want to keep functions re-used across components.
ps48
approved these changes
Jul 23, 2024
TackAdam
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 8d4ba26) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Signed-off-by: Adam Tackett <[email protected]> Co-authored-by: Adam Tackett <[email protected]> (cherry picked from commit 8d4ba26) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Jul 23, 2024
(cherry picked from commit 8d4ba26) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
ps48
pushed a commit
that referenced
this pull request
Jul 23, 2024
(cherry picked from commit 8d4ba26) Signed-off-by: Adam Tackett <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a toast message and error to getting started asset creation.
Screen.Recording.2024-07-23.at.2.33.21.PM.mov
Fixes a bug in trace analytics while the new nav changes are active concerning breadcrumbs.
Before Fix:
https://github.com/user-attachments/assets/e503910c-b547-4031-a6e9-90b09275cc68
After fix:
https://github.com/user-attachments/assets/1ba8af89-be4a-4493-b118-933cf19a0470
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.